Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2fc623e authored by Yijing Wang's avatar Yijing Wang Committed by Tejun Heo
Browse files

ata: fix acpi_bus_get_device() return value check 



Since acpi_bus_get_device() returns plain int and not acpi_status,
ACPI_FAILURE() should not be used for checking its return value.  Fix
that.

tj: Dropped unused local variable @status from odd_can_poweroff().
    Reported by kbuild test bot.

Signed-off-by: default avatarYijing Wang <wangyijing@huawei.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarAaron Lu <aaron.lu@intel.com>
Cc: linux-ide@vger.kernel.org
Cc: kbuild test robot <fengguang.wu@intel.com>
parent 6c9e1499

drivers/ata/libata-zpodd.c

+1 −3
Original line number Diff line number Diff line
@@ -88,15 +88,13 @@ static enum odd_mech_type zpodd_get_mech_type(struct ata_device *dev) 
static bool odd_can_poweroff(struct ata_device *ata_dev)

{

	acpi_handle handle;

	acpi_status status;

	struct acpi_device *acpi_dev;



	handle = ata_dev_acpi_handle(ata_dev);

	if (!handle)

		return false;



	status = acpi_bus_get_device(handle, &acpi_dev);

	if (ACPI_FAILURE(status))

	if (acpi_bus_get_device(handle, &acpi_dev))

		return false;



	return acpi_device_can_poweroff(acpi_dev);