Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7b95315 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

tg3: Don't check undefined error bits in RXBD 



Redefine the RXD_ERR_MASK to include only relevant error bits. This fixes
a customer reported issue of randomly dropping packets on the 5719.

Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent accfe0e3

drivers/net/ethernet/broadcom/tg3.c

+1 −2
Original line number Diff line number Diff line
@@ -6843,8 +6843,7 @@ static int tg3_rx(struct tg3_napi *tnapi, int budget) 


		work_mask |= opaque_key;



		if ((desc->err_vlan & RXD_ERR_MASK) != 0 &&

		    (desc->err_vlan != RXD_ERR_ODD_NIBBLE_RCVD_MII)) {

		if (desc->err_vlan & RXD_ERR_MASK) {

		drop_it:

			tg3_recycle_rx(tnapi, tpr, opaque_key,

				       desc_idx, *post_ptr);

drivers/net/ethernet/broadcom/tg3.h

+5 −1
Original line number Diff line number Diff line
@@ -2608,7 +2608,11 @@ struct tg3_rx_buffer_desc { 
#define RXD_ERR_TOO_SMALL		0x00400000

#define RXD_ERR_NO_RESOURCES		0x00800000

#define RXD_ERR_HUGE_FRAME		0x01000000

#define RXD_ERR_MASK			0xffff0000



#define RXD_ERR_MASK	(RXD_ERR_BAD_CRC | RXD_ERR_COLLISION |		\

			 RXD_ERR_LINK_LOST | RXD_ERR_PHY_DECODE |	\

			 RXD_ERR_MAC_ABRT | RXD_ERR_TOO_SMALL |		\

			 RXD_ERR_NO_RESOURCES | RXD_ERR_HUGE_FRAME)



	u32				reserved;

	u32				opaque;