Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5dc28eb authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger
Browse files

target: remove the t_se_count field in struct se_cmd 



Now that tasks are gone we are guaranteed to only get a single completion
per command, and thus don't need this counter.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent d43d6aea

drivers/target/target_core_transport.c

+0 −6
Original line number Diff line number Diff line
@@ -3284,11 +3284,6 @@ static void transport_put_cmd(struct se_cmd *cmd) 
			goto out_busy;

	}



	if (atomic_read(&cmd->t_se_count)) {

		if (!atomic_dec_and_test(&cmd->t_se_count))

			goto out_busy;

	}



	if (cmd->transport_state & CMD_T_DEV_ACTIVE) {

		cmd->transport_state &= ~CMD_T_DEV_ACTIVE;

		target_remove_from_state_list(cmd);
@@ -3498,7 +3493,6 @@ int transport_generic_new_cmd(struct se_cmd *cmd) 
	}



	atomic_inc(&cmd->t_fe_count);

	atomic_inc(&cmd->t_se_count);



	/*

	 * For WRITEs, let the fabric know its buffer is ready.

include/target/target_core_base.h

+0 −1
Original line number Diff line number Diff line
@@ -548,7 +548,6 @@ struct se_cmd { 
	unsigned char		__t_task_cdb[TCM_MAX_COMMAND_SIZE];

	unsigned long long	t_task_lba;

	atomic_t		t_fe_count;

	atomic_t		t_se_count;

	unsigned int		transport_state;

#define CMD_T_ABORTED		(1 << 0)

#define CMD_T_ACTIVE		(1 << 1)