Commit d1d0589a authored May 04, 2012 by Bjarke Istrup Pedersen Committed by H. Peter Anvin May 04, 2012

arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver



It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.

The wiki article about it confuses it, since it contradicts itself,
regarding what turns on the LED.

I have tested 3.4-rc2 on my net5501 with this patch, and it makes the LED
behave correctly, where "none" turns it off, and "default-on" turns it on,
when echoed onto the trigger "file" in /sys/class/leds.

Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Link: http://lkml.kernel.org/r/20120504210146.62186A018B@akpm.mtv.corp.google.com


Cc: Philip Prindeville <philipp@redfish-solutions.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

parent 7c77cda0

arch/x86/platform/geode/net5501.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
		.name = "net5501:1",
		.gpio = 6,
		.default_trigger = "default-on",
		.active_low = 1,
		.active_low = 0,
		},
		};