Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2218e26 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Linus Torvalds
Browse files

firmware/google: drop 'select EFI' to avoid recursive dependency



The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI.  This
causes problems on other archs when introducing DMI support that depends
on EFI, as it results in a recursive dependency:

  arch/arm/Kconfig:1845:error: recursive dependency detected!
  arch/arm/Kconfig:1845:	symbol DMI depends on EFI

Fix by changing the 'select EFI' to a 'depends on EFI'.

Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Rientjes <rientjes@google.com>
Acked-by: default avatarMike Waychison <mikew@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 592f6b84
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -12,8 +12,7 @@ menu "Google Firmware Drivers"

config GOOGLE_SMI
	tristate "SMI interface for Google platforms"
	depends on ACPI && DMI
	select EFI
	depends on ACPI && DMI && EFI
	select EFI_VARS
	help
	  Say Y here if you want to enable SMI callbacks for Google