Commit b56a39ac authored Jun 16, 2012 by Yuanhan Liu Committed by Greg Kroah-Hartman Jun 16, 2012

printk: return -EINVAL if the message len is bigger than the buf size



Just like what devkmsg_read() does, return -EINVAL if the message len is
bigger than the buf size, or it will trigger a segfault error.

Acked-by: Kay Sievers <kay@vrfy.org>
Acked-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4a77a5a0

kernel/printk.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -880,7 +880,9 @@ static int syslog_print(char __user *buf, int size)
		syslog_seq++;
		raw_spin_unlock_irq(&logbuf_lock);

		if (len > 0 && copy_to_user(buf, text, len))
		if (len > size)
		len = -EINVAL;
		else if (len > 0 && copy_to_user(buf, text, len))
		len = -EFAULT;

		kfree(text);