Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b360a3ce authored by Thomas Hellstrom's avatar Thomas Hellstrom
Browse files

drm/vmwgfx: Fix surface framebuffer check for guest-backed surfaces 



With guest-backed surfaces, surface->sizes == NULL, causing a kernel oops.
Use the base_size member instead.

Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: default avatarJakob Bornecrantz <jakob@vmware.com>
Reviewed-by: default avatarBrian Paul <brianp@vmware.com>
parent 7cba9062

drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

+3 −3
Original line number Diff line number Diff line
@@ -672,9 +672,9 @@ static int vmw_kms_new_framebuffer_surface(struct vmw_private *dev_priv, 


	if (unlikely(surface->mip_levels[0] != 1 ||

		     surface->num_sizes != 1 ||

		     surface->sizes[0].width < mode_cmd->width ||

		     surface->sizes[0].height < mode_cmd->height ||

		     surface->sizes[0].depth != 1)) {

		     surface->base_size.width < mode_cmd->width ||

		     surface->base_size.height < mode_cmd->height ||

		     surface->base_size.depth != 1)) {

		DRM_ERROR("Incompatible surface dimensions "

			  "for requested mode.\n");

		return -EINVAL;