Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2a14755 authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Daniel Vetter
Browse files

drm/i915: check the return value of intel_dp_i2c_init 



We've been ignoring this return value, so print a nice backtrace in
case it's not what we expected.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarZoltan Nyul <zoltan.nyul@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 15b1d171

drivers/gpu/drm/i915/intel_dp.c

+4 −2
Original line number Diff line number Diff line
@@ -3044,7 +3044,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, 
	struct drm_i915_private *dev_priv = dev->dev_private;

	enum port port = intel_dig_port->port;

	const char *name = NULL;

	int type;

	int type, error;



	/* Preserve the current hw state. */

	intel_dp->DP = I915_READ(intel_dp->output_reg);
@@ -3142,7 +3142,9 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, 
		BUG();

	}



	intel_dp_i2c_init(intel_dp, intel_connector, name);

	error = intel_dp_i2c_init(intel_dp, intel_connector, name);

	WARN(error, "intel_dp_i2c_init failed with error %d for port %c\n",

	     error, port_name(port));



	if (!intel_edp_init_connector(intel_dp, intel_connector)) {

		i2c_del_adapter(&intel_dp->adapter);