Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9784bd4f authored by Heiko Carstens's avatar Heiko Carstens Committed by Martin Schwidefsky
Browse files

s390/vmlogrdr: fix array access in vmlogrdr_open() 



Fix check within vmlogrdr_open() if the minor address is not larger
than the number of array elements.

Found with "smatch":

drivers/s390/char/vmlogrdr.c:318 vmlogrdr_open() warn:
  buffer overflow 'sys_ser' 3 <= 3

Acked-by: default avatarStefan Weinhuber <wein@de.ibm.com>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 0ebfd313

drivers/s390/char/vmlogrdr.c

+1 −1
Original line number Diff line number Diff line
@@ -313,7 +313,7 @@ static int vmlogrdr_open (struct inode *inode, struct file *filp) 
	int ret;



	dev_num = iminor(inode);

	if (dev_num > MAXMINOR)

	if (dev_num >= MAXMINOR)

		return -ENODEV;

	logptr = &sys_ser[dev_num];