Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9477165e authored by Patrick Titiano's avatar Patrick Titiano Committed by Zhang Rui
Browse files

thermal: rcar-thermal: update thermal zone only when temperature changes 



Avoid updating the thermal zone in case an IRQ was triggered but the
temperature didn't effectively change.
Note this is not a driver issue.
Below is a captured debug trace illustrating the purpose of this patch:
out of 8 thermal zone updates, only 2 are actually necessary.

[   41.120000] rcar_thermal_work(): cctemp=25000
[   41.120000] rcar_thermal_work(): nctemp=30000
[   41.120000] rcar_thermal_work(): temp is now 30000C, update thermal zone
[   58.990000] rcar_thermal_work(): cctemp=30000
[   58.990000] rcar_thermal_work(): nctemp=30000
[   58.990000] rcar_thermal_work(): same temp, do not update thermal zone
[   59.290000] rcar_thermal_work(): cctemp=30000
[   59.290000] rcar_thermal_work(): nctemp=30000
[   59.290000] rcar_thermal_work(): same temp, do not update thermal zone
[   59.590000] rcar_thermal_work(): cctemp=30000
[   59.590000] rcar_thermal_work(): nctemp=30000
[   59.590000] rcar_thermal_work(): same temp, do not update thermal zone
[   59.890000] rcar_thermal_work(): cctemp=30000
[   59.890000] rcar_thermal_work(): nctemp=30000
[   59.890000] rcar_thermal_work(): same temp, do not update thermal zone
[   60.190000] rcar_thermal_work(): cctemp=30000
[   60.190000] rcar_thermal_work(): nctemp=30000
[   60.190000] rcar_thermal_work(): same temp, do not update thermal zone
[   60.490000] rcar_thermal_work(): cctemp=30000
[   60.490000] rcar_thermal_work(): nctemp=30000
[   60.490000] rcar_thermal_work(): same temp, do not update thermal zone
[   60.790000] rcar_thermal_work(): cctemp=30000
[   60.790000] rcar_thermal_work(): nctemp=35000
[   60.790000] rcar_thermal_work(): temp is now 35000C, update thermal zone

I suspect this may be due to sensor sampling accuracy / fluctuation,
but no formal proof.

Signed-off-by: default avatarPatrick Titiano <ptitiano@baylibre.com>
Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
parent 206c0cba

drivers/thermal/rcar_thermal.c

+6 −1
Original line number Diff line number Diff line
@@ -299,11 +299,16 @@ static void _rcar_thermal_irq_ctrl(struct rcar_thermal_priv *priv, int enable) 
static void rcar_thermal_work(struct work_struct *work)

{

	struct rcar_thermal_priv *priv;

	unsigned long cctemp, nctemp;



	priv = container_of(work, struct rcar_thermal_priv, work.work);



	rcar_thermal_get_temp(priv->zone, &cctemp);

	rcar_thermal_update_temp(priv);

	rcar_thermal_irq_enable(priv);



	rcar_thermal_get_temp(priv->zone, &nctemp);

	if (nctemp != cctemp)

		thermal_zone_device_update(priv->zone);

}