Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a76e538 authored by Javier Martin's avatar Javier Martin Committed by Linus Torvalds
Browse files

media: mx2_camera: Fix mbus format handling 



Do not use MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags. The driver
must negotiate with the attached sensor whether the mbus format is UYUV or
YUYV and set CSICR1 configuration accordingly.

This is needed for the video function on mach-imx27_visstrim_m10.c to
perform properly, since an earlier version of this patch has been proven
wrong and has been reverted and a commit, depending on it: "[media]
i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16" is in the mainline.

Signed-off-by: default avatarJavier Martin <javier.martin@vista-silicon.com>
Reviewed-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
[ g.liakhovetski@gmx.de: move a macro definition to a more logical place ]
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
[ Applying directly because Mauro is on vacation - Linus ]
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 887eafd2

drivers/media/video/mx2_camera.c

+22 −5
Original line number Diff line number Diff line
@@ -83,6 +83,7 @@ 
#define CSICR1_INV_DATA		(1 << 3)

#define CSICR1_INV_PCLK		(1 << 2)

#define CSICR1_REDGE		(1 << 1)

#define CSICR1_FMT_MASK		(CSICR1_PACK_DIR | CSICR1_SWAP16_EN)



#define SHIFT_STATFF_LEVEL	22

#define SHIFT_RXFF_LEVEL	19
@@ -230,6 +231,7 @@ struct mx2_prp_cfg { 
	u32 src_pixel;

	u32 ch1_pixel;

	u32 irq_flags;

	u32 csicr1;

};



/* prp resizing parameters */
@@ -330,6 +332,7 @@ static struct mx2_fmt_cfg mx27_emma_prp_table[] = { 
			.ch1_pixel	= 0x2ca00565, /* RGB565 */

			.irq_flags	= PRP_INTR_RDERR | PRP_INTR_CH1WERR |

						PRP_INTR_CH1FC | PRP_INTR_LBOVF,

			.csicr1		= 0,

		}

	},

	{
@@ -343,6 +346,21 @@ static struct mx2_fmt_cfg mx27_emma_prp_table[] = { 
			.irq_flags	= PRP_INTR_RDERR | PRP_INTR_CH2WERR |

					PRP_INTR_CH2FC | PRP_INTR_LBOVF |

					PRP_INTR_CH2OVF,

			.csicr1		= CSICR1_PACK_DIR,

		}

	},

	{

		.in_fmt		= V4L2_MBUS_FMT_UYVY8_2X8,

		.out_fmt	= V4L2_PIX_FMT_YUV420,

		.cfg		= {

			.channel	= 2,

			.in_fmt		= PRP_CNTL_DATA_IN_YUV422,

			.out_fmt	= PRP_CNTL_CH2_OUT_YUV420,

			.src_pixel	= 0x22000888, /* YUV422 (YUYV) */

			.irq_flags	= PRP_INTR_RDERR | PRP_INTR_CH2WERR |

					PRP_INTR_CH2FC | PRP_INTR_LBOVF |

					PRP_INTR_CH2OVF,

			.csicr1		= CSICR1_SWAP16_EN,

		}

	},

};
@@ -1015,14 +1033,14 @@ static int mx2_camera_set_bus_param(struct soc_camera_device *icd) 
		return ret;

	}



	csicr1 = (csicr1 & ~CSICR1_FMT_MASK) | pcdev->emma_prp->cfg.csicr1;



	if (common_flags & V4L2_MBUS_PCLK_SAMPLE_RISING)

		csicr1 |= CSICR1_REDGE;

	if (common_flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH)

		csicr1 |= CSICR1_SOF_POL;

	if (common_flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)

		csicr1 |= CSICR1_HSYNC_POL;

	if (pcdev->platform_flags & MX2_CAMERA_SWAP16)

		csicr1 |= CSICR1_SWAP16_EN;

	if (pcdev->platform_flags & MX2_CAMERA_EXT_VSYNC)

		csicr1 |= CSICR1_EXT_VSYNC;

	if (pcdev->platform_flags & MX2_CAMERA_CCIR)
@@ -1033,8 +1051,6 @@ static int mx2_camera_set_bus_param(struct soc_camera_device *icd) 
		csicr1 |= CSICR1_GCLK_MODE;

	if (pcdev->platform_flags & MX2_CAMERA_INV_DATA)

		csicr1 |= CSICR1_INV_DATA;

	if (pcdev->platform_flags & MX2_CAMERA_PACK_DIR_MSB)

		csicr1 |= CSICR1_PACK_DIR;



	pcdev->csicr1 = csicr1;
@@ -1109,7 +1125,8 @@ static int mx2_camera_get_formats(struct soc_camera_device *icd, 
		return 0;

	}



	if (code == V4L2_MBUS_FMT_YUYV8_2X8) {

	if (code == V4L2_MBUS_FMT_YUYV8_2X8 ||

	    code == V4L2_MBUS_FMT_UYVY8_2X8) {

		formats++;

		if (xlate) {

			/*