Commit 84a7c0b1 authored Jun 07, 2014 by Manuel Schölling Committed by David S. Miller Jun 11, 2014

dns_resolver: assure that dns_query() result is null-terminated



dns_query() credulously assumes that keys are null-terminated and
returns a copy of a memory block that is off by one.

Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2346829e

net/dns_resolver/dns_query.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -149,7 +149,9 @@ int dns_query(const char type, const char name, size_t namelen,
		if (!*_result)
		goto put;

		memcpy(*_result, upayload->data, len + 1);
		memcpy(*_result, upayload->data, len);
		*_result[len] = '\0';

		if (_expiry)
		*_expiry = rkey->expiry;