Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83a787a7 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: gadget: udc-core: fix wrong call order 



commit 6d258a4c (usb: gadget: udc-core: stop UDC on device-initiated
disconnect) introduced another case of asymmetric calls when issuing
a device-initiated disconnect. Fix it.

Reported-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 15b120d6

drivers/usb/gadget/udc-core.c

+1 −1
Original line number Diff line number Diff line
@@ -415,9 +415,9 @@ static ssize_t usb_udc_softconn_store(struct device *dev, 
			usb_gadget_udc_start(udc->gadget, udc->driver);

		usb_gadget_connect(udc->gadget);

	} else if (sysfs_streq(buf, "disconnect")) {

		usb_gadget_disconnect(udc->gadget);

		if (udc_is_newstyle(udc))

			usb_gadget_udc_stop(udc->gadget, udc->driver);

		usb_gadget_disconnect(udc->gadget);

	} else {

		dev_err(dev, "unsupported command '%s'\n", buf);

		return -EINVAL;