Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f328908 authored by Jens Axboe's avatar Jens Axboe
Browse files

mtip32xx: fix bad use of smp_processor_id()



mtip_pci_probe() dumps the current CPU when loaded, but it does
so in a preemptible context. Hence smp_processor_id() correctly
warns:

BUG: using smp_processor_id() in preemptible [00000000] code: systemd-udevd/155
caller is mtip_pci_probe+0x53/0x880 [mtip32xx]

Switch to raw_smp_processor_id(), since it's just informational
and persistent accuracy isn't important.

Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 10beafc1
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -4498,7 +4498,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
	}
	dev_info(&pdev->dev, "NUMA node %d (closest: %d,%d, probe on %d:%d)\n",
		my_node, pcibus_to_node(pdev->bus), dev_to_node(&pdev->dev),
		cpu_to_node(smp_processor_id()), smp_processor_id());
		cpu_to_node(raw_smp_processor_id()), raw_smp_processor_id());

	dd = kzalloc_node(sizeof(struct driver_data), GFP_KERNEL, my_node);
	if (dd == NULL) {