Commit 71b43fd5 authored May 17, 2012 by Thadeu Lima de Souza Cascardo Committed by Roland Dreier Jun 03, 2012

RDMA/cxgb4: Fix crash when peer address is 0.0.0.0



When using rping -c -a 0.0.0.0 with iw_cxgb4, the system crashes when
rdma_connect() is called.  ip_dev_find() will return NULL, but pdev is
accessed anyway.

Checking that pdev is NULL and returning -ENODEV prevents the system
from crashing.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

parent c23ddf78

drivers/infiniband/hw/cxgb4/cm.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1593,6 +1593,10 @@ static int import_ep(struct c4iw_ep ep, __be32 peer_ip, struct dst_entry dst,
	struct net_device *pdev;		struct net_device *pdev;

	pdev = ip_dev_find(&init_net, peer_ip);		pdev = ip_dev_find(&init_net, peer_ip);
			if (!pdev) {
			err = -ENODEV;
			goto out;
			}
	ep->l2t = cxgb4_l2t_get(cdev->rdev.lldi.l2t,		ep->l2t = cxgb4_l2t_get(cdev->rdev.lldi.l2t,
	n, pdev, 0);		n, pdev, 0);
	if (!ep->l2t)		if (!ep->l2t)