Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e841e32 authored by Liu Bo's avatar Liu Bo Committed by Chris Mason
Browse files

Btrfs: avoid memory leak of extent state in error handling routine 



We've forgotten to clear extent states in pinned tree, which will results in
space counter mismatch and memory leak:

WARNING: at fs/btrfs/extent-tree.c:7537 btrfs_free_block_groups+0x1f3/0x2e0 [btrfs]()
...
space_info 2 has 8380416 free, is not full
space_info total=12582912, used=4096, pinned=4096, reserved=0, may_use=0, readonly=4194304
btrfs state leak: start 29364224 end 29376511 state 1 in tree ffff880075f20090 refs 1
...

Signed-off-by: default avatarLiu Bo <liubo2009@cn.fujitsu.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent 4e42ae1b

fs/btrfs/disk-io.c

+2 −0
Original line number Diff line number Diff line
@@ -3601,6 +3601,8 @@ void btrfs_cleanup_one_transaction(struct btrfs_transaction *cur_trans, 


	btrfs_destroy_marked_extents(root, &cur_trans->dirty_pages,

				     EXTENT_DIRTY);

	btrfs_destroy_pinned_extent(root,

				    root->fs_info->pinned_extents);



	/*

	memset(cur_trans, 0, sizeof(*cur_trans));