Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 665ebe92 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: sb_mixer: missing return statement 



The if condition here was supposed to return on error but the return
statement is missing.  The effect is that the ->mixername is set to
"???" instead of "DT019X".

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ff2354bc

sound/isa/sb/sb_mixer.c

+8 −6
Original line number Diff line number Diff line
@@ -818,12 +818,14 @@ int snd_sbmixer_new(struct snd_sb *chip) 
			return err;

		break;

	case SB_HW_DT019X:

		if ((err = snd_sbmixer_init(chip,

		err = snd_sbmixer_init(chip,

				       snd_dt019x_controls,

				       ARRAY_SIZE(snd_dt019x_controls),

				       snd_dt019x_init_values,

				       ARRAY_SIZE(snd_dt019x_init_values),

					    "DT019X")) < 0)

				       "DT019X");

		if (err < 0)

			return err;

		break;

	default:

		strcpy(card->mixername, "???");