Commit 54031109 authored Jan 23, 2011 by Jesper Juhl Committed by James Morris Jan 24, 2011

trusted keys: Fix a memory leak in trusted_update().



One failure path in security/keys/trusted.c::trusted_update() does
not free 'new_p' while the others do. This patch makes sure we also free
it in the remaining path (if datablob_parse() returns different from
Opt_update).

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: James Morris <jmorris@namei.org>

parent 7f3c68be

security/keys/trusted.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1032,6 +1032,7 @@ static int trusted_update(struct key key, const void data, size_t datalen)
		ret = datablob_parse(datablob, new_p, new_o);
		if (ret != Opt_update) {
		ret = -EINVAL;
		kfree(new_p);
		goto out;
		}
		/* copy old key values, and reseal with new pcrs */