Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b6cc728 authored by Johannes Berg's avatar Johannes Berg Committed by David S. Miller
Browse files

netlink: clarify attribute length check documentation 



The documentation for how the length of attributes
is checked is wrong ("Exact length" isn't true, the
policy checks are for "minimum length") and a bit
misleading. Make it more complete and explain what
really happens.

Cc: Thomas Graf <tgraf@suug.ch>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c30bc947

include/net/netlink.h

+9 −2
Original line number Diff line number Diff line
@@ -192,8 +192,15 @@ enum { 
 *    NLA_NUL_STRING       Maximum length of string (excluding NUL)

 *    NLA_FLAG             Unused

 *    NLA_BINARY           Maximum length of attribute payload

 *    NLA_NESTED_COMPAT    Exact length of structure payload

 *    All other            Exact length of attribute payload

 *    NLA_NESTED           Don't use `len' field -- length verification is

 *                         done by checking len of nested header (or empty)

 *    NLA_NESTED_COMPAT    Minimum length of structure payload

 *    NLA_U8, NLA_U16,

 *    NLA_U32, NLA_U64,

 *    NLA_MSECS            Leaving the length field zero will verify the

 *                         given type fits, using it verifies minimum length

 *                         just like "All other"

 *    All other            Minimum length of attribute payload

 *

 * Example:

 * static const struct nla_policy my_policy[ATTR_MAX+1] = {