Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b5ebccc authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: correct behaviour on unrecognised action frames 



When receiving an "individually addressed" action frame, the
receiver is required to return it to the sender. mac80211
gets this wrong as it also returns group addressed (mcast)
frames to the sender. Fix this and update the reference to
the new 802.11 standards version since things were shuffled
around significantly.

Cc: stable@kernel.org
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 7508b657

net/mac80211/rx.c

+4 −1
Original line number Diff line number Diff line
@@ -2455,7 +2455,7 @@ ieee80211_rx_h_action_return(struct ieee80211_rx_data *rx) 
	 * frames that we didn't handle, including returning unknown

	 * ones. For all other modes we will return them to the sender,

	 * setting the 0x80 bit in the action category, as required by

	 * 802.11-2007 7.3.1.11.

	 * 802.11-2012 9.24.4.

	 * Newer versions of hostapd shall also use the management frame

	 * registration mechanisms, but older ones still use cooked

	 * monitor interfaces so push all frames there.
@@ -2465,6 +2465,9 @@ ieee80211_rx_h_action_return(struct ieee80211_rx_data *rx) 
	     sdata->vif.type == NL80211_IFTYPE_AP_VLAN))

		return RX_DROP_MONITOR;



	if (is_multicast_ether_addr(mgmt->da))

		return RX_DROP_MONITOR;



	/* do not return rejected action frames */

	if (mgmt->u.action.category & 0x80)

		return RX_DROP_UNUSABLE;