Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40606dba authored by Stephen Warren's avatar Stephen Warren Committed by Mark Brown
Browse files

regmap: mmio: convert some error returns to BUG() 



Some of the error conditions detected by regmap_mmio_*() are pure internal
errors, rather than user-/client-triggerable conditions. Convert these to
BUG().

Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 45f5ff81

drivers/base/regmap/regmap-mmio.c

+8 −8
Original line number Diff line number Diff line
@@ -35,8 +35,8 @@ static int regmap_mmio_gather_write(void *context, 
	struct regmap_mmio_context *ctx = context;

	u32 offset;



	if (reg_size != 4)

		return -EIO;

	BUG_ON(reg_size != 4);



	if (val_size % ctx->val_bytes)

		return -EIO;
@@ -60,7 +60,7 @@ static int regmap_mmio_gather_write(void *context, 
#endif

		default:

			/* Should be caught by regmap_mmio_check_config */

			return -EIO;

			BUG();

		}

		val_size -= ctx->val_bytes;

		val += ctx->val_bytes;
@@ -72,8 +72,8 @@ static int regmap_mmio_gather_write(void *context, 


static int regmap_mmio_write(void *context, const void *data, size_t count)

{

	if (count < 4)

		return -EIO;

	BUG_ON(count < 4);



	return regmap_mmio_gather_write(context, data, 4, data + 4, count - 4);

}
@@ -84,8 +84,8 @@ static int regmap_mmio_read(void *context, 
	struct regmap_mmio_context *ctx = context;

	u32 offset;



	if (reg_size != 4)

		return -EIO;

	BUG_ON(reg_size != 4);



	if (val_size % ctx->val_bytes)

		return -EIO;
@@ -109,7 +109,7 @@ static int regmap_mmio_read(void *context, 
#endif

		default:

			/* Should be caught by regmap_mmio_check_config */

			return -EIO;

			BUG();

		}

		val_size -= ctx->val_bytes;

		val += ctx->val_bytes;