Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3916e1d7 authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/udl: fix stride issues scanning out stride != width*bpp 



When buffer sharing with the i915 and using a 1680x1050 monitor,
the i915 gives is a 6912 buffer for the 6720 width, the code doesn't
render this properly as it uses one value to set the base address for
reading from the vmap and for where to start on the device.

This fixes it by calculating the values correctly for the device and
for the pixmap. No idea how I haven't seen this before now.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent a2e4919a

drivers/gpu/drm/udl/udl_drv.h

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ udl_fb_user_fb_create(struct drm_device *dev, 


int udl_render_hline(struct drm_device *dev, int bpp, struct urb **urb_ptr,

		     const char *front, char **urb_buf_ptr,

		     u32 byte_offset, u32 byte_width,

		     u32 byte_offset, u32 device_byte_offset, u32 byte_width,

		     int *ident_ptr, int *sent_ptr);



int udl_dumb_create(struct drm_file *file_priv,

drivers/gpu/drm/udl/udl_fb.c

+7 −5
Original line number Diff line number Diff line
@@ -116,6 +116,7 @@ static void udlfb_dpy_deferred_io(struct fb_info *info, 
		if (udl_render_hline(dev, (ufbdev->ufb.base.bits_per_pixel / 8),

				     &urb, (char *) info->fix.smem_start,

				     &cmd, cur->index << PAGE_SHIFT,

				     cur->index << PAGE_SHIFT,

				     PAGE_SIZE, &bytes_identical, &bytes_sent))

			goto error;

		bytes_rendered += PAGE_SIZE;
@@ -187,10 +188,11 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y, 
	for (i = y; i < y + height ; i++) {

		const int line_offset = fb->base.pitches[0] * i;

		const int byte_offset = line_offset + (x * bpp);



		const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp);

		if (udl_render_hline(dev, bpp, &urb,

				     (char *) fb->obj->vmapping,

				     &cmd, byte_offset, width * bpp,

				     &cmd, byte_offset, dev_byte_offset,

				     width * bpp,

				     &bytes_identical, &bytes_sent))

			goto error;

	}

drivers/gpu/drm/udl/udl_transfer.c

+3 −2
Original line number Diff line number Diff line
@@ -213,11 +213,12 @@ static void udl_compress_hline16( 
 */

int udl_render_hline(struct drm_device *dev, int bpp, struct urb **urb_ptr,

		     const char *front, char **urb_buf_ptr,

		     u32 byte_offset, u32 byte_width,

		     u32 byte_offset, u32 device_byte_offset,

		     u32 byte_width,

		     int *ident_ptr, int *sent_ptr)

{

	const u8 *line_start, *line_end, *next_pixel;

	u32 base16 = 0 + (byte_offset / bpp) * 2;

	u32 base16 = 0 + (device_byte_offset / bpp) * 2;

	struct urb *urb = *urb_ptr;

	u8 *cmd = *urb_buf_ptr;

	u8 *cmd_end = (u8 *) urb->transfer_buffer + urb->transfer_buffer_length;