Commit 0b7d25c3 authored Jan 23, 2014 by Christian Engelmayer Committed by Thierry Reding Feb 26, 2014

pwm: lp3943: Fix potential memory leak during request



Fix a memory leak in the lp3943_pwm_request_map() error handling path.
Make sure already allocated pwm map memory is freed correctly.
Detected by Coverity: CID 1162829.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Acked-by: Milo Kim <milo.kim@ti.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 38dbfb59

drivers/pwm/pwm-lp3943.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -52,9 +52,11 @@ lp3943_pwm_request_map(struct lp3943_pwm *lp3943_pwm, int hwpwm)
		offset = pwm_map->output[i];

		/* Return an error if the pin is already assigned */
		if (test_and_set_bit(offset, &lp3943->pin_used))
		if (test_and_set_bit(offset, &lp3943->pin_used)) {
		kfree(pwm_map);
		return ERR_PTR(-EBUSY);
		}
		}

		return pwm_map;
		}