Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47a8467c authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Fix return value from efx_ethtool_set_rx_ntuple() 



ethtool_ops::set_rx_ntuple is supposed to return 0 on success, but it
currently returns the filter ID when it inserts or modifies a filter.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent 7be799a7

drivers/net/sfc/ethtool.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -955,8 +955,9 @@ static int efx_ethtool_set_rx_ntuple(struct net_device *net_dev, 




	if (ntuple->fs.action == ETHTOOL_RXNTUPLE_ACTION_CLEAR)

	if (ntuple->fs.action == ETHTOOL_RXNTUPLE_ACTION_CLEAR)

		return efx_filter_remove_filter(efx, &filter);

		return efx_filter_remove_filter(efx, &filter);

	else



		return efx_filter_insert_filter(efx, &filter, true);

	rc = efx_filter_insert_filter(efx, &filter, true);

	return rc < 0 ? rc : 0;

}

}





static int efx_ethtool_get_rxfh_indir(struct net_device *net_dev,

static int efx_ethtool_get_rxfh_indir(struct net_device *net_dev,