Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80868c8e authored by David Howells's avatar David Howells Committed by Mauro Carvalho Chehab
Browse files

[media] ts2020: Add a comment about lifetime of on-stack pdata in ts2020_attach() 



ts2020_attach() allocates a variable pdata on the stack and then passes a
pointer to it to i2c_new_device() which stashes the pointer in persistent
structures.

Add a comment to the effect that this isn't actually an error because the
contents of the variable are only used in ts2020_probe() and this is only
called ts2020_attach()'s stack frame exists.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent f158cbce

drivers/media/dvb-frontends/ts2020.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -363,6 +363,8 @@ struct dvb_frontend *ts2020_attach(struct dvb_frontend *fe, 
{

{

	struct i2c_client *client;

	struct i2c_client *client;

	struct i2c_board_info board_info;

	struct i2c_board_info board_info;



	/* This is only used by ts2020_probe() so can be on the stack */

	struct ts2020_config pdata;

	struct ts2020_config pdata;





	memcpy(&pdata, config, sizeof(pdata));

	memcpy(&pdata, config, sizeof(pdata));