Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d3475c0 authored by Bryan Schumaker's avatar Bryan Schumaker Committed by J. Bruce Fields
Browse files

NFSD: forget_delegations should use list_for_each_entry_safe 



Otherwise the for loop could try to use a file recently removed from the
file_hashtbl list and oops.

Signed-off-by: default avatarBryan Schumaker <bjschuma@netapp.com>
Tested-by: default avatarCasey Bodley <cbodley@citi.umich.edu>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 39c4cc0f

fs/nfsd/nfs4state.c

+5 −4
Original line number Diff line number Diff line
@@ -4505,18 +4505,19 @@ void nfsd_forget_openowners(u64 num) 
int nfsd_process_n_delegations(u64 num, void (*deleg_func)(struct nfs4_delegation *))

{

	int i, count = 0;

	struct nfs4_file *fp;

	struct nfs4_delegation *dp, *next;

	struct nfs4_file *fp, *fnext;

	struct nfs4_delegation *dp, *dnext;



	for (i = 0; i < FILE_HASH_SIZE; i++) {

		list_for_each_entry(fp, &file_hashtbl[i], fi_hash) {

			list_for_each_entry_safe(dp, next, &fp->fi_delegations, dl_perfile) {

		list_for_each_entry_safe(fp, fnext, &file_hashtbl[i], fi_hash) {

			list_for_each_entry_safe(dp, dnext, &fp->fi_delegations, dl_perfile) {

				deleg_func(dp);

				if (++count == num)

					return count;

			}

		}

	}



	return count;

}