Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1595ab5d authored by Adrian Bunk's avatar Adrian Bunk Committed by Jeff Garzik
Browse files

[netdrvr] uninline atl1e_setup_mac_ctrl() 



There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl()
is marked as "inline":

It's not used in any place where speed would matter much, and as long as
it has only one caller non-ancient gcc versions anyway inline it
automatically.

This patch fixes the following compile error with gcc 3.4:

<--  snip  -->

...
  CC      drivers/net/atl1e/atl1e_main.o
atl1e_main.c: In function `atl1e_check_link':
atl1e_main.c:50: sorry, unimplemented: inlining failed in call to
atl1e_main.c:196: sorry, unimplemented: called from here
make[4]: *** [drivers/net/atl1e/atl1e_main.o] Error 1

<--  snip  -->

Reported-by: default avatarAdrian Bunk <bunk@kernel.org>
Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 11d89d63

drivers/net/atl1e/atl1e_main.c

+2 −2
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ MODULE_DESCRIPTION("Atheros 1000M Ethernet Network Driver"); 
MODULE_LICENSE("GPL");

MODULE_VERSION(DRV_VERSION);



static inline void atl1e_setup_mac_ctrl(struct atl1e_adapter *adapter);

static void atl1e_setup_mac_ctrl(struct atl1e_adapter *adapter);



static const u16

atl1e_rx_page_vld_regs[AT_MAX_RECEIVE_QUEUE][AT_PAGE_NUM_PER_QUEUE] =
@@ -1037,7 +1037,7 @@ static inline void atl1e_configure_dma(struct atl1e_adapter *adapter) 
	return;

}



static inline void atl1e_setup_mac_ctrl(struct atl1e_adapter *adapter)

static void atl1e_setup_mac_ctrl(struct atl1e_adapter *adapter)

{

	u32 value;

	struct atl1e_hw *hw = &adapter->hw;