Commit 08d2f347 authored May 04, 2011 by Jan Schmidt Committed by Chris Mason Jun 10, 2011

Btrfs: fix extent state leak on failed nodatasum reads



When encountering an EIO while reading from a nodatasum extent, we
insert an error record into the inode's failure tree.
btrfs_readpage_end_io_hook returns early for nodatasum inodes. We'd
better clear the failure tree in that case, otherwise the kernel
complains about

	BUG extent_state: Objects remaining on kmem_cache_close()

on rmmod.

Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Signed-off-by: Chris Mason <chris.mason@oracle.com>

parent 0e735872

fs/btrfs/inode.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1986,7 +1986,7 @@ static int btrfs_readpage_end_io_hook(struct page *page, u64 start, u64 end,
	}		}

	if (BTRFS_I(inode)->flags & BTRFS_INODE_NODATASUM)		if (BTRFS_I(inode)->flags & BTRFS_INODE_NODATASUM)
	return 0;		goto good;

	if (root->root_key.objectid == BTRFS_DATA_RELOC_TREE_OBJECTID &&		if (root->root_key.objectid == BTRFS_DATA_RELOC_TREE_OBJECTID &&
	test_range_bit(io_tree, start, end, EXTENT_NODATASUM, 1, NULL)) {		test_range_bit(io_tree, start, end, EXTENT_NODATASUM, 1, NULL)) {