Commit a0ece285 authored Sep 05, 2010 by Julia Lawall Committed by David S. Miller Sep 06, 2010

drivers/atm/firestream.c: Fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 29af9309

drivers/atm/firestream.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -444,7 +444,7 @@ static inline void fs_kfree_skb (struct sk_buff * skb)
	#define ROUND_NEAREST 3		#define ROUND_NEAREST 3
	/******** make rate (not quite as much fun as Horizon) ********/		/******** make rate (not quite as much fun as Horizon) ********/

	static unsigned int make_rate (unsigned int rate, int r,		static int make_rate(unsigned int rate, int r,
	u16 bits, unsigned int actual)		u16 bits, unsigned int actual)
	{		{
	unsigned char exp = -1; /* hush gcc */		unsigned char exp = -1; /* hush gcc */