Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59c17ec1 authored by Akinobu Mita's avatar Akinobu Mita Committed by James Bottomley
Browse files

[SCSI] iscsi: fix crypto_alloc_hash() error check 



The return value of crypto_alloc_hash() should be checked by
IS_ERR().

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent c959e1c2

drivers/scsi/iscsi_tcp.c

+2 −2
Original line number Diff line number Diff line
@@ -1777,13 +1777,13 @@ iscsi_tcp_conn_create(struct iscsi_cls_session *cls_session, uint32_t conn_idx) 
	tcp_conn->tx_hash.tfm = crypto_alloc_hash("crc32c", 0,

						  CRYPTO_ALG_ASYNC);

	tcp_conn->tx_hash.flags = 0;

	if (!tcp_conn->tx_hash.tfm)

	if (IS_ERR(tcp_conn->tx_hash.tfm))

		goto free_tcp_conn;



	tcp_conn->rx_hash.tfm = crypto_alloc_hash("crc32c", 0,

						  CRYPTO_ALG_ASYNC);

	tcp_conn->rx_hash.flags = 0;

	if (!tcp_conn->rx_hash.tfm)

	if (IS_ERR(tcp_conn->rx_hash.tfm))

		goto free_tx_tfm;



	return cls_conn;