Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 592600a0 authored by Auke Kok's avatar Auke Kok Committed by Auke Kok
Browse files

e1000: check return value of _get_speed_and_duplex 



We were not checking the return value of get_speed_and_duplex
properly, whih may contain an error value.

Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarAuke Kok <auke-jan.h.kok@intel.com>
parent ee04022a

drivers/net/e1000/e1000_hw.c

+6 −2
Original line number Diff line number Diff line
@@ -2737,7 +2737,11 @@ e1000_check_for_link(struct e1000_hw *hw) 
         */

        if(hw->tbi_compatibility_en) {

            uint16_t speed, duplex;

            e1000_get_speed_and_duplex(hw, &speed, &duplex);

            ret_val = e1000_get_speed_and_duplex(hw, &speed, &duplex);

            if (ret_val) {

                DEBUGOUT("Error getting link speed and duplex\n");

                return ret_val;

            }

            if (speed != SPEED_1000) {

                /* If link speed is not set to gigabit speed, we do not need

                 * to enable TBI compatibility.