Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30c52bcf authored by Hante Meuleman's avatar Hante Meuleman Committed by John W. Linville
Browse files

brcmfmac: fix debug printout of event data. 



Some events result in printing of the buffer when debug is
enabled. This printing was not very efficient. Changed to
macro so it comes out nice and clean without filling log buffer.

Reviewed-by: default avatarArend Van Spriel <arend@broadcom.com>
Signed-off-by: default avatarHante Meuleman <meuleman@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent e5806072

drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c

+4 −9
Original line number Original line Diff line number Diff line
@@ -433,13 +433,7 @@ brcmf_c_show_host_event(struct brcmf_event_msg *event, void *event_data) 
	}

	}





	/* show any appended data */

	/* show any appended data */

	if (datalen) {

	brcmf_dbg_hex_dump(datalen, event_data, datalen, "Received data");

		buf = (unsigned char *) event_data;

		brcmf_dbg(EVENT, " data (%d) : ", datalen);

		for (i = 0; i < datalen; i++)

			brcmf_dbg(EVENT, " 0x%02x ", *buf++);

		brcmf_dbg(EVENT, "\n");

	}

}

}

#endif				/* DEBUG */

#endif				/* DEBUG */
@@ -530,6 +524,7 @@ brcmf_c_host_event(struct brcmf_pub *drvr, int *ifidx, void *pktdata, 
	}

	}





#ifdef DEBUG

#ifdef DEBUG

	if (BRCMF_EVENT_ON())

		brcmf_c_show_host_event(event, event_data);

		brcmf_c_show_host_event(event, event_data);

#endif /* DEBUG */

#endif /* DEBUG */

drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -55,6 +55,7 @@ do { \ 
#define BRCMF_HDRS_ON()		(brcmf_msg_level & BRCMF_HDRS_VAL)

#define BRCMF_HDRS_ON()		(brcmf_msg_level & BRCMF_HDRS_VAL)

#define BRCMF_BYTES_ON()	(brcmf_msg_level & BRCMF_BYTES_VAL)

#define BRCMF_BYTES_ON()	(brcmf_msg_level & BRCMF_BYTES_VAL)

#define BRCMF_GLOM_ON()		(brcmf_msg_level & BRCMF_GLOM_VAL)

#define BRCMF_GLOM_ON()		(brcmf_msg_level & BRCMF_GLOM_VAL)

#define BRCMF_EVENT_ON()	(brcmf_msg_level & BRCMF_EVENT_VAL)





#else	/* (defined DEBUG) || (defined DEBUG) */

#else	/* (defined DEBUG) || (defined DEBUG) */
@@ -65,6 +66,7 @@ do { \ 
#define BRCMF_HDRS_ON()		0

#define BRCMF_HDRS_ON()		0

#define BRCMF_BYTES_ON()	0

#define BRCMF_BYTES_ON()	0

#define BRCMF_GLOM_ON()		0

#define BRCMF_GLOM_ON()		0

#define BRCMF_EVENT_ON()	0





#endif				/* defined(DEBUG) */

#endif				/* defined(DEBUG) */