Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffc56630 authored by Laxman Dewangan's avatar Laxman Dewangan
Browse files

gpio: mxc: Use devm_gpiochip_add_data() for gpio registration 



Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.

Signed-off-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
parent 00b9ab4a

drivers/gpio/gpio-mxc.c

+2 −4
Original line number Diff line number Diff line
@@ -462,14 +462,14 @@ static int mxc_gpio_probe(struct platform_device *pdev) 
	port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :

					     pdev->id * 32;



	err = gpiochip_add_data(&port->gc, port);

	err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);

	if (err)

		goto out_bgio;



	irq_base = irq_alloc_descs(-1, 0, 32, numa_node_id());

	if (irq_base < 0) {

		err = irq_base;

		goto out_gpiochip_remove;

		goto out_bgio;

	}



	port->domain = irq_domain_add_legacy(np, 32, irq_base, 0,
@@ -492,8 +492,6 @@ static int mxc_gpio_probe(struct platform_device *pdev) 
	irq_domain_remove(port->domain);

out_irqdesc_free:

	irq_free_descs(irq_base, 32);

out_gpiochip_remove:

	gpiochip_remove(&port->gc);

out_bgio:

	dev_info(&pdev->dev, "%s failed with errno %d\n", __func__, err);

	return err;