Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff937938 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

sctp: dubious bitfields in sctp_transport 



Sparse complains because these one-bit bitfields are signed.
  include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield
  include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield
  include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield
  include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield
  include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield

It doesn't cause a problem in the current code, but it would be better
to clean it up.  This was introduced by c0058a35: "sctp: Save some
room in the sctp_transport by using bitfields".

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ed0f160a

include/net/sctp/structs.h

+1 −1
Original line number Diff line number Diff line
@@ -876,7 +876,7 @@ struct sctp_transport { 


	/* Reference counting. */

	atomic_t refcnt;

	int	 dead:1,

	__u32	 dead:1,

		/* RTO-Pending : A flag used to track if one of the DATA

		 *		chunks sent to this address is currently being

		 *		used to compute a RTT. If this flag is 0,