Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fee32378 authored by Arend van Spriel's avatar Arend van Spriel Committed by Greg Kroah-Hartman
Browse files

staging: brcm80211: use native error code in brcmf_c_pattern_atoh() 



The function brcmf_c_pattern_atoh() returned meaningless -1 value.
These have been replaced by linux error code -EINVAL.

Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Reviewed-by: default avatarRoland Vossen <rvossen@broadcom.com>
Reviewed-by: default avatarFranky Lin <frankyl@broadcom.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a918137a

drivers/staging/brcm80211/brcmfmac/dhd_common.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -841,12 +841,12 @@ static int brcmf_c_pattern_atoh(char *src, char *dst) 
	int i;

	int i;

	if (strncmp(src, "0x", 2) != 0 && strncmp(src, "0X", 2) != 0) {

	if (strncmp(src, "0x", 2) != 0 && strncmp(src, "0X", 2) != 0) {

		BRCMF_ERROR(("Mask invalid format. Needs to start with 0x\n"));

		BRCMF_ERROR(("Mask invalid format. Needs to start with 0x\n"));

		return -1;

		return -EINVAL;

	}

	}

	src = src + 2;		/* Skip past 0x */

	src = src + 2;		/* Skip past 0x */

	if (strlen(src) % 2 != 0) {

	if (strlen(src) % 2 != 0) {

		BRCMF_ERROR(("Mask invalid format. Length must be even.\n"));

		BRCMF_ERROR(("Mask invalid format. Length must be even.\n"));

		return -1;

		return -EINVAL;

	}

	}

	for (i = 0; *src != '\0'; i++) {

	for (i = 0; *src != '\0'; i++) {

		char num[3];

		char num[3];