Commit fda2b418 authored Oct 29, 2014 by Dan Carpenter Committed by Greg Kroah-Hartman Nov 05, 2014

goldfish: off by one in goldfish_tty_console_setup()



The goldfish_ttys[] array has "goldfish_tty_line_count" number of
elements.  It's allocated in goldfish_tty_create_driver().  This test
should be >= instead of >.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a4dc9236

drivers/tty/goldfish.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -155,7 +155,7 @@ static struct tty_driver goldfish_tty_console_device(struct console c,

		static int goldfish_tty_console_setup(struct console co, char options)
		{
		if ((unsigned)co->index > goldfish_tty_line_count)
		if ((unsigned)co->index >= goldfish_tty_line_count)
		return -ENODEV;
		if (!goldfish_ttys[co->index].base)
		return -ENODEV;