Commit fcc9aec3 authored May 03, 2014 by Dan Carpenter Committed by Christian Borntraeger May 06, 2014

KVM: s390: return -EFAULT if copy_from_user() fails



When copy_from_user() fails, this code returns the number of bytes
remaining instead of a negative error code.  The positive number is
returned to the user but otherwise it is harmless.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

parent 57b5981c

arch/s390/kvm/guestdbg.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -223,9 +223,10 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu,
		goto error;
		}

		ret = copy_from_user(bp_data, dbg->arch.hw_bp, size);
		if (ret)
		if (copy_from_user(bp_data, dbg->arch.hw_bp, size)) {
		ret = -EFAULT;
		goto error;
		}

		for (i = 0; i < dbg->arch.nr_hw_bp; i++) {
		switch (bp_data[i].type) {