Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbc4040b authored by Markus Elfring's avatar Markus Elfring Committed by Nicholas Bellinger
Browse files

target: Delete error messages for failed memory allocations 

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 55ec4092

drivers/target/target_core_rd.c

+5 −18
Original line number Diff line number Diff line
@@ -48,10 +48,8 @@ static int rd_attach_hba(struct se_hba *hba, u32 host_id) 
	struct rd_host *rd_host;



	rd_host = kzalloc(sizeof(struct rd_host), GFP_KERNEL);

	if (!rd_host) {

		pr_err("Unable to allocate memory for struct rd_host\n");

	if (!rd_host)

		return -ENOMEM;

	}



	rd_host->rd_host_id = host_id;
@@ -148,11 +146,8 @@ static int rd_allocate_sgl_table(struct rd_dev *rd_dev, struct rd_dev_sg_table * 


		sg = kcalloc(sg_per_table + chain_entry, sizeof(*sg),

				GFP_KERNEL);

		if (!sg) {

			pr_err("Unable to allocate scatterlist array"

				" for struct rd_dev\n");

		if (!sg)

			return -ENOMEM;

		}



		sg_init_table(sg, sg_per_table + chain_entry);
@@ -211,11 +206,8 @@ static int rd_build_device_space(struct rd_dev *rd_dev) 


	sg_tables = (total_sg_needed / max_sg_per_table) + 1;

	sg_table = kcalloc(sg_tables, sizeof(*sg_table), GFP_KERNEL);

	if (!sg_table) {

		pr_err("Unable to allocate memory for Ramdisk"

		       " scatterlist tables\n");

	if (!sg_table)

		return -ENOMEM;

	}



	rd_dev->sg_table_array = sg_table;

	rd_dev->sg_table_count = sg_tables;
@@ -271,11 +263,8 @@ static int rd_build_prot_space(struct rd_dev *rd_dev, int prot_length, int block 


	sg_tables = (total_sg_needed / max_sg_per_table) + 1;

	sg_table = kcalloc(sg_tables, sizeof(*sg_table), GFP_KERNEL);

	if (!sg_table) {

		pr_err("Unable to allocate memory for Ramdisk protection"

		       " scatterlist tables\n");

	if (!sg_table)

		return -ENOMEM;

	}



	rd_dev->sg_prot_array = sg_table;

	rd_dev->sg_prot_count = sg_tables;
@@ -297,10 +286,8 @@ static struct se_device *rd_alloc_device(struct se_hba *hba, const char *name) 
	struct rd_host *rd_host = hba->hba_ptr;



	rd_dev = kzalloc(sizeof(struct rd_dev), GFP_KERNEL);

	if (!rd_dev) {

		pr_err("Unable to allocate memory for struct rd_dev\n");

	if (!rd_dev)

		return NULL;

	}



	rd_dev->rd_host = rd_host;