Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb52c3b5 authored by Nisar Sayed's avatar Nisar Sayed Committed by David S. Miller
Browse files

lan78xx: USB fast connect/disconnect crash fix 



USB fast connect/disconnect crash fix

When USB plugged/unplugged at fast rate,
lan78xx_mdio_init() in lan78xx_bind() failing case is not handled.
Whenever  lan78xx_mdio_init() failed, dev->mdiobus will be freed, however
since lan78xx_bind() not consider as error and try to proceed for
further initialization in lan78xx_probe() which leads system hung/crash.
Also when register_netdev() failed, netdev is freed without calling lan78xx_unbind().
Hence halting the failed cases right manner fixes the system crash/hung issue.

Signed-off-by: default avatarNisar Sayed <Nisar.Sayed@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 12c5d0c0

drivers/net/usb/lan78xx.c

+6 −6
Original line number Diff line number Diff line
@@ -2858,13 +2858,13 @@ static int lan78xx_bind(struct lan78xx_net *dev, struct usb_interface *intf) 
	/* Init all registers */

	ret = lan78xx_reset(dev);



	lan78xx_mdio_init(dev);

	ret = lan78xx_mdio_init(dev);



	dev->net->flags |= IFF_MULTICAST;



	pdata->wol = WAKE_MAGIC;



	return 0;

	return ret;

}



static void lan78xx_unbind(struct lan78xx_net *dev, struct usb_interface *intf)
@@ -3525,10 +3525,10 @@ static int lan78xx_probe(struct usb_interface *intf, 
	udev = interface_to_usbdev(intf);

	udev = usb_get_dev(udev);



	ret = -ENOMEM;

	netdev = alloc_etherdev(sizeof(struct lan78xx_net));

	if (!netdev) {

		dev_err(&intf->dev, "Error: OOM\n");

		ret = -ENOMEM;

		goto out1;

	}
@@ -3610,7 +3610,7 @@ static int lan78xx_probe(struct usb_interface *intf, 
	ret = register_netdev(netdev);

	if (ret != 0) {

		netif_err(dev, probe, netdev, "couldn't register the device\n");

		goto out2;

		goto out3;

	}



	usb_set_intfdata(intf, dev);