Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb3ab105 authored by Roel Kluin's avatar Roel Kluin Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: stv0900: dereference of state->internal in fe_stv0900_error stv0900_init_internal() 



state->internal allocation may fail as well as the allocation of
stv0900_first_inode or new_node->next_inode in append_internal().

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6adb21c8

drivers/media/dvb/frontends/stv0900_core.c

+7 −0
Original line number Diff line number Diff line
@@ -1384,7 +1384,14 @@ static enum fe_stv0900_error stv0900_init_internal(struct dvb_frontend *fe, 
	} else {

		state->internal = kmalloc(sizeof(struct stv0900_internal),

								GFP_KERNEL);

		if (state->internal == NULL)

			return STV0900_INVALID_HANDLE;

		temp_int = append_internal(state->internal);

		if (temp_int == NULL) {

			kfree(state->internal);

			state->internal = NULL;

			return STV0900_INVALID_HANDLE;

		}

		state->internal->dmds_used = 1;

		state->internal->i2c_adap = state->i2c_adap;

		state->internal->i2c_addr = state->config->demod_address;