Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fad7da7b authored by Gilad Ben-Yossef's avatar Gilad Ben-Yossef Committed by Greg Kroah-Hartman
Browse files

staging: ccree: NULLify backup_info when unused 



commit 46df8824982e4fb0198776078d4a8c3e2d531464 upstream.

backup_info field is only allocated for decrypt code path.
The field was not nullified when not used causing a kfree
in an error handling path to attempt to free random
addresses as uncovered in stress testing.

Fixes: 737aed94 ("staging: ccree: save ciphertext for CTS IV")
Signed-off-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a4b5ee9

drivers/staging/ccree/ssi_cipher.c

+1 −0
Original line number Diff line number Diff line
@@ -904,6 +904,7 @@ static int ssi_ablkcipher_decrypt(struct ablkcipher_request *req) 
	scatterwalk_map_and_copy(req_ctx->backup_info, req->src,

				 (req->nbytes - ivsize), ivsize, 0);

	req_ctx->is_giv = false;

	req_ctx->backup_info = NULL;



	return ssi_blkcipher_process(tfm, req_ctx, req->dst, req->src, req->nbytes, req->info, ivsize, (void *)req, DRV_CRYPTO_DIRECTION_DECRYPT);

}