Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa7f86f1 authored by Ying Xue's avatar Ying Xue Committed by David S. Miller
Browse files

tipc: optimize the initialization of network device notifier 



Ethernet media initialization is only done when TIPC is started or
switched to network mode. So the initialization of the network device
notifier structure can be moved out of this function and done
statically instead.

Signed-off-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fff3321d

net/tipc/eth_media.c

+10 −3
Original line number Diff line number Diff line
@@ -58,7 +58,16 @@ struct eth_bearer { 
static struct tipc_media eth_media_info;

static struct eth_bearer eth_bearers[MAX_ETH_BEARERS];

static int eth_started;

static struct notifier_block notifier;



static int recv_notification(struct notifier_block *nb, unsigned long evt,

			      void *dv);

/*

 * Network device notifier info

 */

static struct notifier_block notifier = {

	.notifier_call	= recv_notification,

	.priority	= 0

};



/**

 * eth_media_addr_set - initialize Ethernet media address structure
@@ -357,8 +366,6 @@ int tipc_eth_media_start(void) 
	if (res)

		return res;



	notifier.notifier_call = &recv_notification;

	notifier.priority = 0;

	res = register_netdevice_notifier(&notifier);

	if (!res)

		eth_started = 1;