Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9d03814 authored by Javi Merino's avatar Javi Merino Committed by Eduardo Valentin
Browse files

thermal: power_allocator: req_range multiplication should be a 64 bit type 



req_range is declared as a u64 to cope with overflows in the
multiplication of two u32.  As both req_power and power_range are u32,
we need to make sure the multiplication is done with u64 types.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: default avatarJavi Merino <javi.merino@arm.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent c0ff8aaa

drivers/thermal/power_allocator.c

+1 −1
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ static void divvy_up_power(u32 *req_power, u32 *max_power, int num_actors, 
	capped_extra_power = 0;

	extra_power = 0;

	for (i = 0; i < num_actors; i++) {

		u64 req_range = req_power[i] * power_range;

		u64 req_range = (u64)req_power[i] * power_range;



		granted_power[i] = DIV_ROUND_CLOSEST_ULL(req_range,

							 total_req_power);