Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9287c1f authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Theodore Ts'o
Browse files

ext4: ext4_mkdir should dirty dir_block with newly created directory inode 



ext4_mkdir calls ext4_handle_dirty_metadata with dir_block and the inode "dir".
Unfortunately, dir_block belongs to the newly created directory (which is
"inode"), not the parent directory (which is "dir").  Fix the incorrect
association.

Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
parent bcaa9929

fs/ext4/namei.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1862,7 +1862,7 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, int mode) 
	ext4_set_de_type(dir->i_sb, de, S_IFDIR);

	ext4_set_de_type(dir->i_sb, de, S_IFDIR);

	inode->i_nlink = 2;

	inode->i_nlink = 2;

	BUFFER_TRACE(dir_block, "call ext4_handle_dirty_metadata");

	BUFFER_TRACE(dir_block, "call ext4_handle_dirty_metadata");

	err = ext4_handle_dirty_metadata(handle, dir, dir_block);

	err = ext4_handle_dirty_metadata(handle, inode, dir_block);

	if (err)

	if (err)

		goto out_clear_inode;

		goto out_clear_inode;

	err = ext4_mark_inode_dirty(handle, inode);

	err = ext4_mark_inode_dirty(handle, inode);