Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8bd4934 authored by Jingoo Han's avatar Jingoo Han Committed by Florian Tobias Schandinat
Browse files

video: use gpio_request_one 



Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Acked-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 1c16697b

drivers/video/bf537-lq035.c

+3 −9
Original line number Diff line number Diff line
@@ -383,23 +383,19 @@ static int __devinit request_ports(void) 
	}



#if (defined(UD) && defined(LBR))

	if (gpio_request(UD, KBUILD_MODNAME)) {

	if (gpio_request_one(UD, GPIOF_OUT_INIT_LOW, KBUILD_MODNAME)) {

		pr_err("requesting GPIO %d failed\n", UD);

		return -EBUSY;

	}



	if (gpio_request(LBR, KBUILD_MODNAME)) {

	if (gpio_request_one(LBR, GPIOF_OUT_INIT_HIGH, KBUILD_MODNAME)) {

		pr_err("requesting GPIO %d failed\n", LBR);

		gpio_free(UD);

		return -EBUSY;

	}



	gpio_direction_output(UD, 0);

	gpio_direction_output(LBR, 1);



#endif



	if (gpio_request(MOD, KBUILD_MODNAME)) {

	if (gpio_request_one(MOD, GPIOF_OUT_INIT_HIGH, KBUILD_MODNAME)) {

		pr_err("requesting GPIO %d failed\n", MOD);

#if (defined(UD) && defined(LBR))

		gpio_free(LBR);
@@ -408,8 +404,6 @@ static int __devinit request_ports(void) 
		return -EBUSY;

	}



	gpio_direction_output(MOD, 1);



	SSYNC();

	return 0;

}

drivers/video/bf54x-lq043fb.c

+1 −3
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ static int request_ports(struct bfin_bf54xfb_info *fbi) 
	u16 eppi_req_18[] = EPPI0_18;

	u16 disp = fbi->mach_info->disp;



	if (gpio_request(disp, DRIVER_NAME)) {

	if (gpio_request_one(disp, GPIOF_OUT_INIT_HIGH, DRIVER_NAME)) {

		printk(KERN_ERR "Requesting GPIO %d failed\n", disp);

		return -EFAULT;

	}
@@ -263,8 +263,6 @@ static int request_ports(struct bfin_bf54xfb_info *fbi) 
		}

	}



	gpio_direction_output(disp, 1);



	return 0;

}

drivers/video/bfin-lq035q1-fb.c

+4 −4
Original line number Diff line number Diff line
@@ -365,10 +365,10 @@ static int __devinit bfin_lq035q1_request_ports(struct platform_device *pdev, 
	 * Drive PPI_FS3 Low

	 */

	if (ANOMALY_05000400) {

		int ret = gpio_request(P_IDENT(P_PPI0_FS3), "PPI_FS3");

		int ret = gpio_request_one(P_IDENT(P_PPI0_FS3),

					GPIOF_OUT_INIT_LOW, "PPI_FS3");

		if (ret)

			return ret;

		gpio_direction_output(P_IDENT(P_PPI0_FS3), 0);

	}



	if (ppi16)
@@ -716,14 +716,14 @@ static int __devinit bfin_lq035q1_probe(struct platform_device *pdev) 
	}



	if (info->disp_info->use_bl) {

		ret = gpio_request(info->disp_info->gpio_bl, "LQ035 Backlight");

		ret = gpio_request_one(info->disp_info->gpio_bl,

					GPIOF_OUT_INIT_LOW, "LQ035 Backlight");



		if (ret) {

			dev_err(&pdev->dev, "failed to request GPIO %d\n",

				info->disp_info->gpio_bl);

			goto out9;

		}

		gpio_direction_output(info->disp_info->gpio_bl, 0);

	}



	ret = register_framebuffer(fbinfo);

drivers/video/bfin_adv7393fb.c

+3 −2
Original line number Diff line number Diff line
@@ -411,12 +411,13 @@ static int __devinit bfin_adv7393_fb_probe(struct i2c_client *client, 


	/* Workaround "PPI Does Not Start Properly In Specific Mode" */

	if (ANOMALY_05000400) {

		if (gpio_request(P_IDENT(P_PPI0_FS3), "PPI0_FS3")) {

		ret = gpio_request_one(P_IDENT(P_PPI0_FS3), GPIOF_OUT_INIT_LOW,

					"PPI0_FS3")

		if (ret) {

			dev_err(&client->dev, "PPI0_FS3 GPIO request failed\n");

			ret = -EBUSY;

			goto out_8;

		}

		gpio_direction_output(P_IDENT(P_PPI0_FS3), 0);

	}



	if (peripheral_request_list(ppi_pins, DRIVER_NAME)) {

drivers/video/msm/mddi_client_nt35399.c

+1 −6
Original line number Diff line number Diff line
@@ -155,14 +155,10 @@ static int setup_vsync(struct panel_info *panel, int init) 
		ret = 0;

		goto uninit;

	}

	ret = gpio_request(gpio, "vsync");

	ret = gpio_request_one(gpio, GPIOF_IN, "vsync");

	if (ret)

		goto err_request_gpio_failed;



	ret = gpio_direction_input(gpio);

	if (ret)

		goto err_gpio_direction_input_failed;



	ret = irq = gpio_to_irq(gpio);

	if (ret < 0)

		goto err_get_irq_num_failed;
@@ -180,7 +176,6 @@ static int setup_vsync(struct panel_info *panel, int init) 
	free_irq(gpio_to_irq(gpio), panel->client_data);

err_request_irq_failed:

err_get_irq_num_failed:

err_gpio_direction_input_failed:

	gpio_free(gpio);

err_request_gpio_failed:

	return ret;