Commit f7dd795e authored Jan 08, 2006 by Oleg Nesterov Committed by Linus Torvalds Jan 08, 2006

[PATCH] setpgid: should not accept ptraced childs

sys_setpgid() allows to change ->pgrp of ptraced childs.

'man setpgid' does not tell anything about that, so I consider
this behaviour is a bug.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Oren Laadan <orenl@cs.columbia.edu>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent e19f247a

kernel/sys.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1114,7 +1114,7 @@ asmlinkage long sys_setpgid(pid_t pid, pid_t pgid)
	if (!thread_group_leader(p))		if (!thread_group_leader(p))
	goto out;		goto out;

	if (p->parent == current \|\| p->real_parent == group_leader) {		if (p->real_parent == group_leader) {
	err = -EPERM;		err = -EPERM;
	if (p->signal->session != group_leader->signal->session)		if (p->signal->session != group_leader->signal->session)
	goto out;		goto out;