Commit f679a840 authored Sep 24, 2009 by Yan, Zheng Committed by Chris Mason Sep 24, 2009

Btrfs: don't rename file into dummy directory

A recent change enforces only one access point to each subvolume. The first
directory entry (the one added when the subvolume/snapshot was created) is
treated as valid access point, all other subvolume links are linked to dummy
empty directories. The dummy directories are temporary inodes that only in
memory, so we can not rename file into them.

Signed-off-by: Yan Zheng <zheng.yan@oracle.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>

parent a5719521

fs/btrfs/inode.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -5055,6 +5055,9 @@ static int btrfs_rename(struct inode old_dir, struct dentry old_dentry,
		u64 root_objectid;
		int ret;

		if (new_dir->i_ino == BTRFS_EMPTY_SUBVOL_DIR_OBJECTID)
		return -EPERM;

		/* we only allow rename subvolume link between subvolumes */
		if (old_inode->i_ino != BTRFS_FIRST_FREE_OBJECTID && root != dest)
		return -EXDEV;