Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f623ce95 authored by Joerg Roedel's avatar Joerg Roedel Committed by Rob Herring
Browse files

of: Introduce of_for_each_phandle() helper macro 



With this macro any user can easily iterate over a list of
phandles. The patch also converts __of_parse_phandle_with_args()
to make use of the macro.

The of_count_phandle_with_args() function is not converted,
because the macro hides the return value of of_phandle_iterator_init(),
which is needed in there.

Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 2021bd01

drivers/of/base.c

+1 −6
Original line number Diff line number Diff line
@@ -1543,13 +1543,8 @@ static int __of_parse_phandle_with_args(const struct device_node *np, 
	struct of_phandle_iterator it;

	int rc, cur_index = 0;



	rc = of_phandle_iterator_init(&it, np, list_name,

				      cells_name, cell_count);

	if (rc)

		return rc;



	/* Loop over the phandles until all the requested entry is found */

	while ((rc = of_phandle_iterator_next(&it)) == 0) {

	of_for_each_phandle(&it, rc, np, list_name, cells_name, cell_count) {

		/*

		 * All of the error cases bail out of the loop, so at

		 * this point, the parsing is successful. If the requested

include/linux/of.h

+6 −0
Original line number Diff line number Diff line
@@ -908,6 +908,12 @@ static inline int of_property_read_s32(const struct device_node *np, 
	return of_property_read_u32(np, propname, (u32*) out_value);

}



#define of_for_each_phandle(it, err, np, ln, cn, cc)			\

	for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)),	\

	     err = of_phandle_iterator_next(it);			\

	     err == 0;							\

	     err = of_phandle_iterator_next(it))



#define of_property_for_each_u32(np, propname, prop, p, u)	\

	for (prop = of_find_property(np, propname, NULL),	\

		p = of_prop_next_u32(prop, NULL, &u);		\