Commit f5ef95b1 authored Jun 04, 2014 by Joe Perches Committed by Linus Torvalds Jun 04, 2014

checkpatch: warn on #defines ending in semicolon



Using a #define ending in a semicolon is poor style and can lead to
unexpected code paths being executed.

Warn on uses of these #define types:

	#define foo[(...)] bar;
	#define foo[(...)]	\
		bar;

Based on a patch from Borislav Petkov.

Signed-off-by: Joe Perches <joe@perches.com>
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2ac73b4f

scripts/checkpatch.pl

+11 −0

Original line number	Diff line number	Diff line
		@@ -3821,6 +3821,17 @@ sub process {
		WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
		"do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
		}
		} elsif ($dstat =~ /^\+\s#\sdefine\s+$Ident.;\s$/) {
		$ctx =~ s/\n*$//;
		my $cnt = statement_rawlines($ctx);
		my $herectx = $here . "\n";

		for (my $n = 0; $n < $cnt; $n++) {
		$herectx .= raw_line($linenr, $n) . "\n";
		}

		WARN("TRAILING_SEMICOLON",
		"macros should not use a trailing semicolon\n" . "$herectx");
		}
		}