Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f51a08da authored by Valentin Ilie's avatar Valentin Ilie Committed by Felipe Balbi
Browse files

usb: gadget: mv_u3d_core: fix memory leaks 



When trb_hw is NULL, trb should be free'd before return.

Signed-off-by: default avatarValentin Ilie <valentin.ilie@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 161bfa98

drivers/usb/gadget/mv_u3d_core.c

+2 −0
Original line number Diff line number Diff line
@@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req, 
	 */

	trb_hw = dma_pool_alloc(u3d->trb_pool, GFP_ATOMIC, dma);

	if (!trb_hw) {

		kfree(trb);

		dev_err(u3d->dev,

			"%s, dma_pool_alloc fail\n", __func__);

		return NULL;
@@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req) 


		trb_hw = kcalloc(trb_num, sizeof(*trb_hw), GFP_ATOMIC);

		if (!trb_hw) {

			kfree(trb);

			dev_err(u3d->dev,

					"%s, trb_hw alloc fail\n", __func__);

			return -ENOMEM;